NW7 | Jovy_So | Structuring-and-Testing-Data | WEEK 1 #65
Conversation
There was a problem hiding this comment.
I can see you've worked super hard on thinking about these questions, @jovyso . 💪 Keep going!
| @@ -1,5 +1,5 @@ | |||
| // Currently trying to print the string "I was born in Bolton" but it isn't working... | |||
| // what's the error ? | |||
|
|
|||
| console.log(`I was born in ${cityOfBirth}`); | |||
| const cityOfBirth = "Bolton"; | |||
There was a problem hiding this comment.
Please write in comments don't just fix the code. Thanks!
| @@ -1,4 +1,4 @@ | |||
| const cardNumber = 4533787178994213; | |||
| const cardNumber = "4533787178994213"; | |||
There was a problem hiding this comment.
Is this a good solution do you think? What might the consequences be in changing a number to a string?
| //const 24hourClockTime = "08:53"; | ||
|
|
||
| function convert12To24(time) { |
There was a problem hiding this comment.
Is this what the exercise asked for? Take another look
|
|
||
| // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer | ||
| It works for non-negative values of movieLength. |
There was a problem hiding this comment.
Can a movie have a negative length?
| Now enter just `console` in the Console, what output do you get back? | ||
|
|
||
| -->Answer: console {debug: ƒ, error: ƒ, info: ƒ, log: ƒ, warn: ƒ, …} |
There was a problem hiding this comment.
And what is this showing you?
| Try also entering `typeof console` | ||
|
|
||
| -->Answer: 'object' |
There was a problem hiding this comment.
What conclusion can you draw from this?
| @@ -25,3 +25,9 @@ console.log(`£${pounds}.${pence}`); | |||
|
|
|||
| // To begin, we can start with | |||
| // 1. const penceString = "399p": initialises a string variable with the value "399p" | |||
| // 2. const penceStringWithoutTrailingP = penceString.substring(0,penceString.length - 1): remove "p" | |||
| // 3. const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0"): Pad the pence number string | |||
There was a problem hiding this comment.
What does pad mean? What is it doing?
| // 3. const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0"): Pad the pence number string | ||
| // 4. const pounds = paddedPenceNumberString.substring(0,paddedPenceNumberString.length - 2): Extract pounds | ||
| // 5. const pence = paddedPenceNumberString.substring(paddedPenceNumberString.length - 2).padEnd(2, "0");: Extract pence | ||
| // 6. console.log(`£${pounds}.${pence}`);: Output the Result |
There was a problem hiding this comment.
It's logging something. Is this the same as outputting a result?
SallyMcGrath
added
👀 Review Requirements
samirahekmati
added
Complete
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.